Skip to content

Sort plugin modal tabs #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
+161 −0
Merged

Sort plugin modal tabs #310

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
95ce19a
sort plugin modal tabs
afragen Oct 30, 2025
707e5e1
add additional sections
afragen Oct 31, 2025
d2f7864
add tests, borrowed liberally from @meszarosrob
afragen Oct 31, 2025
2b96148
sort sections in fetch_metadoc_doc for caching
afragen Oct 31, 2025
5f5e269
additional guard
afragen Oct 31, 2025
1a67b12
add tests
afragen Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions inc/packages/admin/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function bootstrap() {
add_action( 'load-plugin-install.php', __NAMESPACE__ . '\\load_plugin_install' );
add_action( 'install_plugins_pre_plugin-information', __NAMESPACE__ . '\\maybe_hijack_plugin_info', 0 );
add_filter( 'plugins_api_result', __NAMESPACE__ . '\\alter_slugs', 10, 3 );
add_filter( 'plugins_api_result', __NAMESPACE__ . '\\sort_sections_in_api', 15, 1 );
add_filter( 'plugin_install_action_links', __NAMESPACE__ . '\\maybe_hijack_plugin_install_button', 10, 2 );
add_filter( 'plugin_install_description', __NAMESPACE__ . '\\maybe_add_data_to_description', 10, 2 );
add_action( 'wp_ajax_check_plugin_dependencies', __NAMESPACE__ . '\\set_slug_to_hashed' );
Expand Down Expand Up @@ -427,6 +428,32 @@ function alter_slugs( $res, $action, $args ) {
return $res;
}

/**
* Sort plugin modal tabs.
*
* Based on standard tab listing order.
*
* @param object|WP_Error $res Response object or WP_Error.
* @return object|WP_Error
*/
function sort_sections_in_api( $res ) {
$ordered_sections = [
'description',
'installation',
'faq',
'screenshots',
'changelog',
'upgrade_notice',
'other_notes',
];
if ( property_exists( $res, 'sections' ) ) {
$properly_ordered = array_merge( array_fill_keys( $ordered_sections, '' ), $res->sections );
$res->sections = array_filter( $properly_ordered );
}

return $res;
}

/**
* Override the install button, for bridged plugins.
*
Expand Down