Use std iterators for some collections #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work there, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom iterators for various collection types, to instead use the built-in iterators from
std(oralloc). This applies toHashMap,HashSet,BTreeMap, andBTreeSet. In addition to simplifying the implementation, this also means we no longer need to.collect()forHashMaporHashSetwhen creating the iterator!This was unblocked by #641 (previously,
HashMapneeded a custom iterator that buffered the keys in order to implementDoubleEndedIterator)As part of this change, the iter vtable for
HashMapno longer provides annext_back, while the iter vtable forBTreeSetnow does provide it