Skip to content

Conversation

@scxiao
Copy link
Contributor

@scxiao scxiao commented Nov 25, 2025

What does this PR do?

Fixes # (issue).

Current implementation for fp8 uses a packed fp8 format, which needs additional unpack steps for dequantization from fp8 to bf16. This PR is to add the support of the non-packed fp8 format for Triton attn decode, it is about 20% to 30% faster than packed format on AMD MI350.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@scxiao scxiao marked this pull request as draft November 25, 2025 21:00
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant