Deprecate make_positive_semidefinite in EigenConfig
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70260187 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Feb 26, 2025
…arch#86) Summary: Deprecate `make_positive_semidefinite` option because we always want to use it. Differential Revision: D70260187
tsunghsienlee
force-pushed
the
export-D70260187
branch
from
575a84a to
88daf5c
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Feb 26, 2025
…arch#86) Summary: Deprecate `make_positive_semidefinite` option because we always want to use it. Differential Revision: D70260187
tsunghsienlee
force-pushed
the
export-D70260187
branch
from
88daf5c to
ba5a11b
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Feb 26, 2025
…arch#86) Summary: Deprecate `make_positive_semidefinite` option because we always want to use it. Differential Revision: D70260187
tsunghsienlee
force-pushed
the
export-D70260187
branch
from
ba5a11b to
39fc867
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70260187 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D70260187 |
…arch#86) Summary: Deprecate `make_positive_semidefinite` option because we always want to use it. Differential Revision: D70260187
tsunghsienlee
force-pushed
the
export-D70260187
branch
from
39fc867 to
a0b2564
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70260187 |
runame
approved these changes
Feb 27, 2025
|
This pull request has been merged in 6ed21ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Deprecate
make_positive_semidefiniteoption because we always want to use it.Differential Revision: D70260187