Enhance CI tests with momentum usages #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Due to the issue at facebookresearch#79, we should enhance our CI tests with `momentum` turned on. This helps us cover the cases when using `momentum`. Differential Revision: D68161955
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68161955 |
runame
approved these changes
Jan 15, 2025
Basically with momentum, we have extra code paths to go through, this is net coverage increase. |
|
This pull request has been merged in 9c5700a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Due to the issue at #79, we should enhance our CI tests with
momentumturned on. This helps us cover the cases when usingmomentum.Differential Revision: D68161955