Fix imports UI

[runame]

Update the imports in distributed_shampoo/__init__.py to reflect the latest changes in matrix_functions_types.py.

[tsunghsienlee]

Just curious that how this was detected because I would like a more robust way to detect this?

[facebook-github-bot]

@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[runame]

Just curious that how this was detected because I would like a more robust way to detect this?

I only discovered this because I was trying to use the package with

from distributed_shampoo import QRConfig

and got an error.

I was also thinking that we should figure out a more robust way of implementing this. I guess one option is to define __all__ in each file and then import with from xyz import * in distributed_shampoo/__init__.py, but this is still not really automatic. I can try to look into this.

[tsunghsienlee]

Just curious that how this was detected because I would like a more robust way to detect this?

I only discovered this because I was trying to use the package with

from distributed_shampoo import QRConfig

and got an error.

I was also thinking that we should figure out a more robust way of implementing this. I guess one option is to define __all__ in each file and then import with from xyz import * in distributed_shampoo/__init__.py, but this is still not really automatic. I can try to look into this.

If using __all__ is for from xyz import *, we might consider not using that because it is considered as a bad practice.

I am thinking it probably is time to merge the open-sourced folder with Meta internal folder to let both side tests/CIs to test each other if their settings don't conflict with each other.

[facebook-github-bot]

@tsunghsienlee merged this pull request in b601aae.