Fix and refactor get_all_subclasses() util in shampoo_types_test.py
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. Fixes the bug that recursive function did not include that `cls` itself into the return result. 2. Adds a new argument `include_cls_self` to the function to control whether to include the class itself in the result. It also includes docstrings to explain how this function works. Differential Revision: D67802249
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67802249 |
runame
approved these changes
Jan 3, 2025
In fact, it was a bug because the recursive traversal will return a empty |
|
This pull request has been merged in c51e4e6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
clsitself into the return result.include_cls_selfto the function to control whether to include the class itself in the result. It also includes docstrings to explain how this function works.Differential Revision: D67802249