Refactor the input argument of BlockInfo.allocate_zeros_tensor() #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67550399 |
…ebookresearch#69) Summary: 1. Change the first argument from `shape` to `size` so the default value of `BlockInfo.allocate_zeros_tensor` could be as simple as `partial(torch.zeros)`. This is also reported in OSS (facebookresearch#25). 2. Comments and typing fixes and improvements. Reviewed By: chuanhaozhuge Differential Revision: D67550399
tsunghsienlee
force-pushed
the
export-D67550399
branch
from
4095f36 to
8d31a5c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67550399 |
runame
approved these changes
Dec 21, 2024
|
This pull request has been merged in 9a43622. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
shapetosizeso the default value ofBlockInfo.allocate_zeros_tensorcould be as simple aspartial(torch.zeros). This is also reported in OSS (replace lambda function #25).Differential Revision: D67550399