Open-sourced update on 12/19/2024 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
b50550a to
27ba711
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
27ba711 to
42f1145
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
42f1145 to
7006084
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
2 times, most recently
from
70a24d9 to
c36c9a2
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
c36c9a2 to
310587f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
310587f to
4ac964c
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 18, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
4ac964c to
45d0d95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
45d0d95 to
e93b7b5
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
e93b7b5 to
440bc1c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now. Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
440bc1c to
cca8b37
Compare
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Dec 19, 2024
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now; as a result, deprecate `precision_config`. 3. Deprecate `use_pytorch_compile`, this is superseded by `shampoo_pt2_compile_config`. 4. Deprecate `use_protected_eigh`, this is always `True` from now. Reviewed By: chuanhaozhuge Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
cca8b37 to
fd774f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
Summary: Pull Request resolved: facebookresearch#63 1. Add `HybridShardDistributor` (i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi into `DistributedShampoo`. 2. Disable quantization functionality for now; as a result, deprecate `precision_config`. 3. Deprecate `use_pytorch_compile`, this is superseded by `shampoo_pt2_compile_config`. 4. Deprecate `use_protected_eigh`, this is always `True` from now. Reviewed By: wz337, chuanhaozhuge Differential Revision: D67398314
tsunghsienlee
force-pushed
the
export-D67398314
branch
from
fd774f8 to
64ca67d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67398314 |
|
This pull request has been merged in ae91e28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
HybridShardDistributor(i.e., per-parameter HSDP or HSDP2) implemented by wz337 and hjmshi intoDistributedShampoo.precision_config.use_pytorch_compile, this is superseded byshampoo_pt2_compile_config.use_protected_eigh, this is alwaysTruefrom now.Differential Revision: D67398314