Fix mypy errors #54
Closed
Fix mypy errors #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tsunghsienlee
approved these changes
Nov 20, 2024
|
@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tsunghsienlee merged this pull request in bfc71b1. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
Summary: According to [CI mypy test](https://github.com/facebookresearch/optimizers/actions/runs/11919205460/job/33218398648), this diff followed #54 to add mypy complains ignore in internal codes. Reviewed By: anana10c Differential Revision: D66219137 fbshipit-source-id: 20d6ed40c6315cf94921d38a88e0764035b7053b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstractmethodsince this seems to be a shortcoming on mypy's side: it doesn't recognize that thedataclassdecorator will take care of__init__.super()call in the__post_init__function ofAdaGradGraftingConfig. I think this is not necessary and mypy complains about inheriting from anabstractmethod.