Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larger runner for github actions test #1665

Merged
merged 10 commits into from
Dec 4, 2024
Merged

larger runner for github actions test #1665

merged 10 commits into from
Dec 4, 2024

Conversation

bottler
Copy link
Contributor

@bottler bottler commented Dec 2, 2024

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 2, 2024
recom = self.recommendations.loc[names, :]
recom.iloc[:, :] = np.round(recom, 10)
print(f"{len(names)=}, {names[1:19]=}")
names = sorted(set(names))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this line cures the OOM. Is that the right thing to do?

@bottler bottler changed the title try larger runner for github actions test larger runner for github actions test Dec 4, 2024
@bottler bottler merged commit c66af15 into main Dec 4, 2024
8 checks passed
@bottler bottler deleted the bottler/actions branch December 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants