Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove imageio-ffmpeg from dependencies. #2519

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 11, 2024

Motivation and Context

The imageio-ffmpeg dependency is not strictly required to run habitat-sim.
This package depends on libva, which depends on libgl, libglx, libegl and libglvnd.
Those 4 last packages may conflict with Linux packages, causing the OpenGL front-end libraries to fail to communicate to the OpenGL backend.
This error may occur:

GL::Context: cannot retrieve OpenGL version: GL::Renderer::Error::InvalidValue

How Has This Been Tested

Tested locally on a new conda environment.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 11, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deprecated the relevant features. This was really a hold-over from the Colab age. We wanted to write the videos as fast as possible to make the cells more interactive. Good to remove if it is causing dependency mixups and friction for folks.

@0mdc 0mdc changed the title [CI] Remove imageio-ffmpeg from conda build run depedencies. [CI] Remove imageio-ffmpeg from dependencies. Dec 11, 2024
@aclegg3
Copy link
Contributor

aclegg3 commented Dec 11, 2024

The failing test indicates that we need to add a lab refactor which is now live in facebookresearch/habitat-lab#2117

@aclegg3
Copy link
Contributor

aclegg3 commented Dec 13, 2024

Re-running the tests after merging the downstream lab refactor.

@aclegg3 aclegg3 merged commit a48e2c0 into main Dec 13, 2024
7 checks passed
@aclegg3 aclegg3 deleted the 0mdc/remove_imageio_ffmpeg_dep branch December 13, 2024 20:39
@qZhang88
Copy link

I am encoutering the same problem with v0.3.2. How could I fix it?

@qZhang88
Copy link

qZhang88 commented Jan 10, 2025

I am encoutering the same problem with v0.3.2. How could I fix it?

Fix it by update viz_utils.py as in in commits and also remove all libva, libgl, libglx, libegl and libglvnd in conda env/lib/ path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants