update bindings variables names and pass the upload flag for nightly …

…osx conda builds (#2533)
facebookresearch · Jan 14, 2025 · 05f51dd · 05f51dd
1 parent ae157a5
commit 05f51dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/install_and_test.yml b/.github/workflows/install_and_test.yml
@@ -437,5 +437,5 @@ jobs:
             conda config --set anaconda_upload yes
             cd conda-build
             export PYTHONIOENCODING="utf-8"
-            python matrix_builder.py ${{ env.NIGHTLY }}
+            python matrix_builder.py --conda_upload ${{ env.NIGHTLY }}
           fi
diff --git a/src/esp/bindings/AttributesManagersBindings.cpp b/src/esp/bindings/AttributesManagersBindings.cpp
@@ -297,7 +297,7 @@ void declareBaseAttributesManager(py::module& m,
             "fail with a message if any subdirectories in the requested "
             "filepath do not exist.")
                .c_str(),
-           "handle"_a, "filepath"_a, "create_subdir"_a)
+           "template"_a, "filepath"_a, "create_subdir"_a)
       .def("save_template_to_filepath",
            static_cast<bool (MgrClass::*)(const AttribsPtr&, const std::string&,
                                           const std::string&, bool) const>(
@@ -309,7 +309,7 @@ void declareBaseAttributesManager(py::module& m,
             "subdirectories in the requested filepath "
             "subdirectories do not exist.")
                .c_str(),
-           "handle"_a, "filepath"_a, "filename"_a, "create_subdir"_a);
+           "template"_a, "filepath"_a, "filename"_a, "create_subdir"_a);
 }  // declareBaseAttributesManager
 
 void initAttributesManagersBindings(py::module& m) {