New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PCF2-Lift Options to a shared location #2198

Open

calebzj wants to merge 1 commit into facebookresearch:main from calebzj:export-D44062784

calebzj commented Mar 17, 2023

Summary: This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

facebook-github-bot added CLA Signed fb-exported labels

Contributor

facebook-github-bot commented Mar 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment

Contributor

facebook-github-bot commented Mar 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 98950f8f15f994a53b6a20e2ed66daecc4b7c2bc

calebzj force-pushed the export-D44062784 branch from 4254489 to 2842869 Compare

March 17, 2023 03:09

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

b54e38e

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 888fbce44832fd5be3fe2e30c7d3fc60cf29f223

calebzj force-pushed the export-D44062784 branch from 2842869 to b54e38e Compare

March 17, 2023 19:17

Contributor

facebook-github-bot commented Mar 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment

Contributor

facebook-github-bot commented Mar 17, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

789efab

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 0f13d31ef882d6eb3b4908fa53a4b7eafe5d1f7c

calebzj force-pushed the export-D44062784 branch from b54e38e to 789efab Compare

March 17, 2023 21:58

Contributor

facebook-github-bot commented Mar 20, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

81992b6

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 4ed6f17f5e0200600324254e58f94904c00d0fa2

calebzj force-pushed the export-D44062784 branch from 789efab to 81992b6 Compare

March 20, 2023 21:27

Contributor

facebook-github-bot commented Mar 24, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj force-pushed the export-D44062784 branch from 81992b6 to 5286b80 Compare

March 24, 2023 21:45

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

5286b80

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 3e1779d48b003ee1ac16dc4e77e47a3c80e0f111

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

215c27b

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: d2ea44f9edaa045666ce5ff0095481af225b243c

calebzj force-pushed the export-D44062784 branch from 5286b80 to 215c27b Compare

March 27, 2023 21:54

Contributor

facebook-github-bot commented Mar 27, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment

Contributor

facebook-github-bot commented Mar 28, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

b880191

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 46b4dc7fc95f14d24eeed32462569f4c3ffad9fe

calebzj force-pushed the export-D44062784 branch from 215c27b to b880191 Compare

March 28, 2023 00:07

Contributor

facebook-github-bot commented Mar 30, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj force-pushed the export-D44062784 branch from b880191 to 8680d5e Compare

March 30, 2023 20:26

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

8680d5e

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 2874edb15d3c5abc67630e1a2192484017866136


          Move PCF2-Lift Options to a shared location (facebookresearch#2198)

6ca79a9

Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: c63c45566219ec11272ac58c2efbb7c7437d1f21

Contributor

facebook-github-bot commented Mar 30, 2023

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj force-pushed the export-D44062784 branch from 8680d5e to 6ca79a9 Compare

March 30, 2023 20:36

Contributor

facebook-github-bot commented Feb 10, 2025

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported