Add utility class to support background server #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
facebook-github-bot
added
the
CLA Signed
JasonKChow
force-pushed
the
pr646
branch
6 times, most recently
from
f0d95d2 to
ca0cb6a
Compare
Summary: Rewrite the server to use asyncio and be multithreaded. Allows handling multiple clients. Test Plan: Tests updated. Later test also tests multiple db writes simultaneously.
Summary: Use scoped sessions that is shared between threads to allow async db operations. Test Plan: Tests should pass
Summary: Logging levels were used inconsistently and would cause problems with multithreaded servers. We remove this ability. Test Plan: Tests updated.
Summary: All message handlers will emit a info logging message to support better live tracking of server functions. Test Plan: Tests should pass
Summary: To support multi client server, strategy methods will not act on copies of models to avoid changing tensor gradients between two threads. Test Plan: New test
Summary: A subclass of the aepsych server with methods specifically to run the server in a background process. This will be used to ensured that even within the same main script, the server will run like an actual server and does not do anything sneaky like bypassing the async queue. Test Plan: New test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A subclass of the aepsych server with methods specifically to run the server in a background process. This will be used to ensured that even within the same main script, the server will run like an actual server and does not do anything sneaky like bypassing the async queue.
Test Plan: New test
Stack created with Sapling. Best reviewed with ReviewStack.