Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to torchrun #116

Merged
merged 1 commit into from
Jun 14, 2023
Merged

updated to torchrun #116

merged 1 commit into from
Jun 14, 2023

Conversation

zstreet87
Copy link
Contributor

@zstreet87 zstreet87 commented Jun 7, 2023 •
edited
Loading

fixes issue #115

@samiwilf

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2023
@samiwilf
Copy link
Contributor

@nrsatish @erichan1

@erichan1
Copy link
Member

Seems ok to me

@zstreet87
Copy link
Contributor Author

can we merge this please?

@erichan1 erichan1 merged commit b3cd99c into facebookresearch:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiwilf samiwilf samiwilf approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zstreet87 @samiwilf @erichan1 @facebook-github-bot