Skip to content

Conversation

gmunoz
Copy link

@gmunoz gmunoz commented Feb 5, 2025

Known to function for Ubuntu 22.04 and 24.04.

Tested with docker tags for ubuntu:24.04 and ubuntu:22.04 using:

docker run \
  -v "$(pwd)":/usr/src \
  -v /sys:/sys:ro \
  --rm \
  -it \
  ubuntu:24.04 \
  /bin/bash -c 'pushd /usr/src && apt update && apt install -y sudo && ./scripts/build.sh'

Known to function for Ubuntu 22.04 and 24.04.
@facebook-github-bot
Copy link
Contributor

Hi @gmunoz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@samuelnair samuelnair requested a review from RihamSelim February 6, 2025 09:42
Copy link
Contributor

@RihamSelim RihamSelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RihamSelim
Copy link
Contributor

@gmunoz Thanks for making this change! We can merge it once you fill in the Contributor License Agreement.

@gmunoz
Copy link
Author

gmunoz commented Mar 5, 2025

@RihamSelim Thanks for the heads up. I lost track of this PR but I'll review the license agreement as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants