drop trailing slash in mapped_manifest_dir for git sources
#83
Conversation
in git sources, when the repo root is the same as the manifest dir, currently reindeer with attempt to join the repo name with an empty path (the manifest sub-path), which produces a path with a trailing slash, due to how `Path::join` works. This path is later used to create the key in a buck2 file-to-source map-dict, which fails, since buck2 does not want trailing slashes in the keys for those maps. this detects if the manifest sub-path would be empty, and skips joining it.
|
Hi @DirectXMan12! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
meta-cla
bot
added
the
CLA Signed
1 participant
in git sources, when the repo root is the same as the manifest dir, currently reindeer with attempt to join the repo name with an empty path (the manifest sub-path), which produces a path with a trailing slash, due to how
Path::joinworks.This path is later used to create the key in a buck2 file-to-source map-dict, which fails, since buck2 does not want trailing slashes in the keys for those maps.
this detects if the manifest sub-path would be empty, and skips joining it.