fix: Handle null constant result in duplicated array and map column readers #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In case of some irregular encodings of deduplicated arrays or maps, specifically:
When the above conditions are all satisfied, the elements vector is changed to a constant vector by
NullColumnReader
first, then we try to write to it because the second key is reusing the value from previous run, so it tries to copy the cached value into result vector, and throw an exception. Fix this by resetting the result if it is not writable (constant or dictionary).Differential Revision: D84085512