[Nimble] Update Velox to fix the build #263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
Looks like the updated velox is failing to build |
macvincent
added a commit
to macvincent/velox
that referenced
this pull request
Sep 30, 2025
…extReader (facebookincubator#15004) Summary: [Bumping the velox version](facebookincubator/nimble#263) used in our Nimble repo leads to this compiler error: `error: reference to local binding 'scale' declared in enclosing function`. The faulty lines were introduced in D82741341. We refactor to fix the compiler error. Differential Revision: D83541640
macvincent
added a commit
to macvincent/velox
that referenced
this pull request
Sep 30, 2025
…extReader (facebookincubator#15004) Summary: [Bumping the velox version](facebookincubator/nimble#263) used in our Nimble repo leads to this compiler error: `error: reference to local binding 'scale' declared in enclosing function`. The faulty lines were introduced in D82741341. We refactor to fix the compiler error. Differential Revision: D83541640
macvincent
added a commit
to macvincent/velox
that referenced
this pull request
Sep 30, 2025
…extReader (facebookincubator#15004) Summary: [Bumping the velox version](facebookincubator/nimble#263) used in our Nimble repo leads to this compiler error: `error: reference to local binding 'scale' declared in enclosing function`. The faulty lines were introduced in D82741341. We refactor to fix the compiler error. Differential Revision: D83541640
macvincent
added a commit
to macvincent/velox
that referenced
this pull request
Sep 30, 2025
…extReader (facebookincubator#15004) Summary: [Bumping the velox version](facebookincubator/nimble#263) used in our Nimble repo leads to this compiler error: `error: reference to local binding 'scale' declared in enclosing function`. The faulty lines were introduced in D82741341. We refactor to fix the compiler error. Differential Revision: D83541640
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Oct 1, 2025
…extReader (#15004) Summary: Pull Request resolved: #15004 [Bumping the velox version](facebookincubator/nimble#263) used in our Nimble repo leads to this compiler error: `error: reference to local binding 'scale' declared in enclosing function`. The faulty lines were introduced in D82741341. We refactor to fix the compiler error. Reviewed By: Yuhta Differential Revision: D83541640 fbshipit-source-id: 2cd3c346cdc97afd64e68cf6316f196ab65d50cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Velox to fix the InMemoryTrackableReadFile build error.