Fix writer regression caused by memory reallocation in ensureNullsCapacity #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D82172070 |
sdruzkin
added a commit
to sdruzkin/nimble
that referenced
this pull request
Sep 11, 2025
…acity (facebookincubator#247) Summary: Fix up to 32x writer regression caused by memory reallocation of the exact size without growing in ensureNullsCapacity by providing the grows policy. This regression was identified by DISCO runs on biggest tables and then narrowed by CPU profiling. Differential Revision: D82172070
sdruzkin
force-pushed
the
export-D82172070
branch
from
98e17c2 to
22eb3d8
Compare
sdruzkin
added a commit
to sdruzkin/nimble
that referenced
this pull request
Sep 11, 2025
…acity (facebookincubator#247) Summary: Fix up to 32x writer regression caused by memory reallocation of the exact size without growing in ensureNullsCapacity by providing the grows policy. This regression was identified by DISCO runs on biggest tables and then narrowed by CPU profiling. Differential Revision: D82172070
|
This pull request was exported from Phabricator. Differential Revision: D82172070 |
sdruzkin
force-pushed
the
export-D82172070
branch
from
22eb3d8 to
d5fd8e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D82172070 |
sdruzkin
added a commit
to sdruzkin/nimble
that referenced
this pull request
Sep 11, 2025
…acity (facebookincubator#247) Summary: Pull Request resolved: facebookincubator#247 Fix up to 32x writer regression caused by memory reallocation of the exact size without growing in ensureNullsCapacity by providing the grows policy. This regression was identified by DISCO runs on biggest tables and then narrowed by CPU profiling. Differential Revision: D82172070
sdruzkin
force-pushed
the
export-D82172070
branch
from
d5fd8e4 to
e64095c
Compare
…acity (facebookincubator#247) Summary: Fix up to 32x writer regression caused by memory reallocation of the exact size without growing in ensureNullsCapacity by providing the grows policy. This regression was identified by DISCO runs on biggest tables and then narrowed by CPU profiling. Differential Revision: D82172070
sdruzkin
force-pushed
the
export-D82172070
branch
from
e64095c to
ba3abfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix up to 32x writer regression caused by memory reallocation of the exact size without growing
in ensureNullsCapacity by providing the grows policy.
This regression was identified by DISCO runs on biggest tables and then narrowed by CPU profiling.
Differential Revision: D82172070