Clean Up Nimble Flush Policy Code #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 2, 2025
Summary: Rollback Plan: Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
92f3053 to
05053ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
force-pushed
the
export-D81514657
branch
from
05053ec to
6bcd2dd
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 2, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 2, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
6bcd2dd to
3341410
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
3341410 to
c5c3f21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
c5c3f21 to
fd4335a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 3, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
fd4335a to
0d5fbbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Sep 4, 2025
Summary: Pull Request resolved: facebookincubator#235 Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
0d5fbbc to
105f95c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
force-pushed
the
export-D81514657
branch
from
105f95c to
007ba1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
force-pushed
the
export-D81514657
branch
from
007ba1a to
54ab6f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81514657 |
macvincent
force-pushed
the
export-D81514657
branch
from
d24d362 to
60e8ecc
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: Pull Request resolved: facebookincubator#235 As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Differential Revision: D81514657 Reviewed By: sdruzkin, helfman
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
60e8ecc to
082fcf2
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 9, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 13, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 13, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
082fcf2 to
3b619cb
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 13, 2025
Summary: Pull Request resolved: facebookincubator#235 As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Differential Revision: D81514657 Reviewed By: sdruzkin, helfman
macvincent
force-pushed
the
export-D81514657
branch
2 times, most recently
from
4a3f71c to
43c3d83
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 14, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 14, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
2 times, most recently
from
0bbf5f5 to
69440b9
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 14, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
69440b9 to
6696c5d
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: facebookincubator#235 As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Differential Revision: D81514657 Reviewed By: sdruzkin, helfman
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 14, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
force-pushed
the
export-D81514657
branch
from
6696c5d to
8051b86
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 16, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Oct 16, 2025
Summary: As preparation for our [Nimble chunked encoding](https://fburl.com/gdoc/zjck7lo6) work, we decided to clean up the previous contract to remove unused methods and attributes. Should be a no-op since these methods and attributes were not used. We also clarified the naming of some attributes. Reviewed By: sdruzkin, helfman Differential Revision: D81514657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D81514657