Fix bug with path arg type and add env var expansion #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-fletcher
requested review from
CrimsonK1ng,
RoboticPrism,
cedowens,
d0n601 and
d3sch41n
as code owners
|
@isaac-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85156301. |
isaac-fletcher
added a commit
to isaac-fletcher/TTPForge
that referenced
this pull request
Oct 24, 2025
…or#571) Summary: The path arg type was not being evaluated based on the path of the TTP YAML. This caused relative paths such as `default: <FILE>` or `default: ./<FILE>` to resolve based on the path you executed ttpforge from as opposed to the path of the YAML. This has been updated to resolve relative to the YAML when provided as a default value and resolve relative to the current working directory when provided as a command-line argument. Additionally added handling for variable expansion within the shell. This should be helpful for TTPs referencing variables like $HOME or alike. Reviewed By: RoboticPrism Differential Revision: D85156301
isaac-fletcher
force-pushed
the
export-D85156301
branch
from
1a5a8b6 to
3c1d16a
Compare
…or#571) Summary: The path arg type was not being evaluated based on the path of the TTP YAML. This caused relative paths such as `default: <FILE>` or `default: ./<FILE>` to resolve based on the path you executed ttpforge from as opposed to the path of the YAML. This has been updated to resolve relative to the YAML when provided as a default value and resolve relative to the current working directory when provided as a command-line argument. Additionally added handling for variable expansion within the shell. This should be helpful for TTPs referencing variables like $HOME or alike. Reviewed By: RoboticPrism Differential Revision: D85156301
isaac-fletcher
force-pushed
the
export-D85156301
branch
from
3c1d16a to
d5b2577
Compare
|
This pull request has been merged in c5c6f02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The path arg type was not being evaluated based on the path of the TTP YAML. This caused relative paths such as
default: <FILE>ordefault: ./<FILE>to resolve based on the path you executed ttpforge from as opposed to the path of the YAML.This has been updated to resolve relative to the YAML when provided as a default value and resolve relative to the current working directory when provided as a command-line argument.
Additionally added handling for variable expansion within the shell. This should be helpful for TTPs referencing variables like $HOME or alike.
Reviewed By: RoboticPrism
Differential Revision: D85156301