Include <fmt/format.h> for fmt::format instead of <fmt/core.h> - #1348
Include <fmt/format.h> for fmt::format instead of <fmt/core.h>#1348daeho-ro wants to merge 1 commit into
Conversation
|
Hi @daeho-ro! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
72cec04 to
7dbd77e
Compare
|
This pull request has been imported. If you are a Meta employee, you can view this in D109432737. (Because this pull request was imported automatically, there will not be any future comments.) |
7dbd77e to
2235635
Compare
|
@daeho-ro has updated the pull request. You must reimport the pull request before landing. |
These files call fmt::format/format_to and included <fmt/core.h>, relying on it to pull in the formatting API. Since fmt 12.2, <fmt/core.h> no longer defines fmt::format (it must be included via <fmt/format.h>), so they fail to compile with "no member named 'format' in namespace 'fmt'". Include <fmt/format.h> directly where fmt::format is used.