Skip to content

Include <fmt/format.h> for fmt::format instead of <fmt/core.h> - #1348

Open
daeho-ro wants to merge 1 commit into
facebook:mainfrom
daeho-ro:fix-fmt-12-format-include
Open

Include <fmt/format.h> for fmt::format instead of <fmt/core.h>#1348
daeho-ro wants to merge 1 commit into
facebook:mainfrom
daeho-ro:fix-fmt-12-format-include

Conversation

@daeho-ro

Copy link
Copy Markdown

These files call fmt::format/format_to and included <fmt/core.h>, relying on it to pull in the formatting API. Since fmt 12.2, <fmt/core.h> no longer defines fmt::format (it must be included via <fmt/format.h>), so they fail to compile with "no member named 'format' in namespace 'fmt'". Include <fmt/format.h> directly where fmt::format is used.

@meta-cla

meta-cla Bot commented Jun 23, 2026

Copy link
Copy Markdown

Hi @daeho-ro!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@daeho-ro
daeho-ro force-pushed the fix-fmt-12-format-include branch from 72cec04 to 7dbd77e Compare June 23, 2026 12:04
@meta-cla meta-cla Bot added the CLA Signed label Jun 23, 2026
@meta-codesync

meta-codesync Bot commented Jun 23, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D109432737. (Because this pull request was imported automatically, there will not be any future comments.)

@daeho-ro
daeho-ro force-pushed the fix-fmt-12-format-include branch from 7dbd77e to 2235635 Compare August 5, 2026 14:28
@facebook-github-tools

Copy link
Copy Markdown

@daeho-ro has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant