Skip to content

Conversation

@ben--
Copy link
Contributor

@ben-- ben-- commented Sep 22, 2025

Three separate improvements needed by the OSS Sapling/EdenFS build:

  1. Add LANGUAGES py3 support to add_fbthrift_library() in make
  2. Add LANGUAGES rustsupport to add_fbthrift_library() in cmake
  3. Add cython support in cmake
  4. Add ability for python binaries to support non-python dependencies (needed by cython)
  5. Switch rust to the nightly build to support #[deprecated]

Tested through building Sapling/EdenFS (requires other fixes to run clean):

act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml

@meta-cla meta-cla bot added the CLA Signed label Sep 22, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83008904. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants