Only run secondary db verification for blackbox crash tests #13341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of #13338, which aims to address crash test failures caused by #13281.
I looked through the test failures again, and they all are for the whitebox tests.
I am pretty sure this is because the whitebox tests have 20 for
reopen
whereas the blackbox tests have 0 insidewhitebox_default_params
andblackbox_default_params
.The error logs for the ASAN and TSAN failures point to the
ReOpen
method, so I think that if we just avoid this code path, we can avoid the failures.I do not think that the whitebox tests give us additional information for the sole purpose of secondary DB verification compared to the blackbox tests. Thus, I think it is likely better to just enable secondary DB verification on blackbox tests only. We still will want to monitor for data verification failures and see no verification failures for an extended period of time.
Test Plan
Monitor recurring crash test runs.
I confirmed the simple blackbox test can give 1 for
test_secondary
.whereas
test_secondary
is not even specified in