Adds Compiler support for remaining Array methods - sort, reduce, and more #33535
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
|
|
||
| ## Input | ||
|
|
||
| ```javascript | ||
| function Component() { | ||
| const array = ['c', 'b', 'a']; | ||
| return useMemo(() => { | ||
| return [...array].copyWithin(0, 2); | ||
| }, [array]); | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| ## Code | ||
|
|
||
| ```javascript | ||
| import { c as _c } from "react/compiler-runtime"; | ||
| function Component() { | ||
| const $ = _c(2); | ||
| let t0; | ||
| if ($[0] === Symbol.for("react.memo_cache_sentinel")) { | ||
| t0 = ["c", "b", "a"]; | ||
| $[0] = t0; | ||
| } else { | ||
| t0 = $[0]; | ||
| } | ||
| const array = t0; | ||
| let t1; | ||
| let t2; | ||
| if ($[1] === Symbol.for("react.memo_cache_sentinel")) { | ||
| t2 = [...array].copyWithin(0, 2); | ||
| $[1] = t2; | ||
| } else { | ||
| t2 = $[1]; | ||
| } | ||
| t1 = t2; | ||
| return t1; | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| ### Eval output | ||
| (kind: exception) Fixture not implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| function Component() { | ||
| const array = ['c', 'b', 'a']; | ||
| return useMemo(() => { | ||
| return [...array].copyWithin(0, 2); | ||
| }, [array]); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
|
|
||
| ## Input | ||
|
|
||
| ```javascript | ||
| function Component() { | ||
| const array = ['c', 'b', 'a']; | ||
| return useMemo(() => { | ||
| return [...array].fill(0); | ||
| }, [array]); | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| ## Code | ||
|
|
||
| ```javascript | ||
| import { c as _c } from "react/compiler-runtime"; | ||
| function Component() { | ||
| const $ = _c(2); | ||
| let t0; | ||
| if ($[0] === Symbol.for("react.memo_cache_sentinel")) { | ||
| t0 = ["c", "b", "a"]; | ||
| $[0] = t0; | ||
| } else { | ||
| t0 = $[0]; | ||
| } | ||
| const array = t0; | ||
| let t1; | ||
| let t2; | ||
| if ($[1] === Symbol.for("react.memo_cache_sentinel")) { | ||
| t2 = [...array].fill(0); | ||
| $[1] = t2; | ||
| } else { | ||
| t2 = $[1]; | ||
| } | ||
| t1 = t2; | ||
| return t1; | ||
| } | ||
|
|
||
| ``` | ||
|
|
||
| ### Eval output | ||
| (kind: exception) Fixture not implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| function Component() { | ||
| const array = ['c', 'b', 'a']; | ||
| return useMemo(() => { | ||
| return [...array].fill(0); | ||
| }, [array]); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is subtle, but the behavior of
fill(value, start, end)is thatvalueis stored into the array (Effect.Capture), while the rest of the args are just read. So a more precise declaration would be: