Skip to content

CI: reduce excessive sharding #33464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CI: reduce excessive sharding #33464

wants to merge 1 commit into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 6, 2025

No description provided.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 6, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 6, 2025

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 876d990

@kassens kassens force-pushed the pr33464 branch 2 times, most recently from b092969 to 4883912 Compare June 6, 2025 17:24
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the sharding isn't great and adds a lot of contention when there are multiple instances of the job running at once. But it's been the only way to get the workflow to take around 5 minutes. If we can not regress build times too much (under 6?), please tweak away but it definitely shouldn't be 10 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants