Reduce false positive of eslint rule exhaustive-deps improving dependency analysis#33462
Closed
seiyab wants to merge 3 commits intofacebook:mainfrom
Closed
Reduce false positive of eslint rule exhaustive-deps improving dependency analysis#33462seiyab wants to merge 3 commits intofacebook:mainfrom
seiyab wants to merge 3 commits intofacebook:mainfrom
Conversation
Signed-off-by: seiya <20365512+seiyab@users.noreply.github.com>
Signed-off-by: seiya <20365512+seiyab@users.noreply.github.com>
Signed-off-by: seiya <20365512+seiyab@users.noreply.github.com>
seiyab
commented
Jun 6, 2025
Comment on lines
-1850
to
+1871
| * Assuming () means the passed/returned node: | ||
| * (props) => (props) | ||
| * props.(foo) => (props.foo) | ||
| * props.foo.(bar) => (props).foo.bar | ||
| * props.foo.bar.(baz) => (props).foo.bar.baz | ||
| * Assuming {} means the passed/returned node and multiple "=>" means recursive calls: | ||
| * {props} => {props} | ||
| * {props}.foo => {props.foo} | ||
| * {props}.foo.bar.baz => {props.foo}.bar.baz => {props.foo.bar}.baz => {props.foo.bar.baz} | ||
| * props.{foo} => props.{foo} | ||
| * props.foo.{bar} => props.foo.{bar} | ||
| * {ref}.current => {ref}.current | ||
| * {props}.foo() => {props}.foo() | ||
| * {foo}.bar.baz=123 => {foo.bar}.baz=123 |
Author
There was a problem hiding this comment.
I'm suspicious of the original comment but not sure enough. Feel free to revert the comment.
seiyab
changed the title
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
Bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This false positive is reported at #16265 (comment) and a member confirmed it is a bug #16265 (comment)
How did you test this change?
Added test cases