Enable fixtures/view-transition deploy to Vercel
#32994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need empty build command. Otherwise Vercel uses static-build instead of static for build/static
github-actions
bot
added
the
React Core Team
eps1lon
commented
Apr 23, 2025
| @@ -13,7 +13,7 @@ module.exports = { | |||
| arrowParens: 'avoid', | |||
| overrides: [ | |||
| { | |||
| files: ['*.code-workspace'], | |||
| files: ['*.code-workspace', '*.json'], | |||
There was a problem hiding this comment.
drive-by to allow force-formatting of .json files. They used to be handled by Hermes parser which can't parse .json files.
eps1lon
commented
Apr 23, 2025
|
|
||
| ## Deploy | ||
|
|
||
| Deployed to https://react-fixture-view-transition-six.vercel.app |
There was a problem hiding this comment.
I don't like the -six suffix. Maybe I accidentally sit on react-fixture-view-transition.vercel.app. I'll double check.
eps1lon
commented
Apr 23, 2025
Comment on lines
9
to
+15
| "dependencies": { | ||
| "@babel/core": "7.26.0", | ||
| "@babel/plugin-proposal-private-property-in-object": "7.21.11", | ||
| "@babel/register": "^7.25.9", | ||
| "babel-preset-react-app": "10.0.1", | ||
| "express": "^4.14.0", | ||
| "http-proxy-middleware": "3.0.3", |
There was a problem hiding this comment.
These are used when running the server so I classified them as prod dependencies. This enables a simple yarn install --production to avoid file limits when deploying. The alternative is bundling the server via ncc but that was its own fight I lost.
Zaid-maker
reviewed
Apr 23, 2025
eps1lon
force-pushed
the
sebbie/vt-deploy-build-output-api
branch
from
77a9784 to
b8fd442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending git integration with facebook/react
Summary
Automatically deploys
fixtures/view-transitionto Vercel (except changes only targettingcompiler/.There's repeated work from
yarn build-for-vt-deploythat could be skipped if we wait for CI. But that requires setting up a webhook which makes testing harder. Let's see if we have issues with starved build containers first.I tried to make it work with zero-config but combining create-react-app with express.js was too much of a hassle. So we directly output Build Output API compatible files. This is what we'd do if we switch to Vite in
vite-plugin-ssranyway.How did you test this change?
Same settings on a fork and
git push. We'll see how it behaves on PRs from forks.