Skip to content

fix(community-cli-plugin): Add description in target debugs to distinguish RN Bridge and reanimated #54198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(community-cli-plugin): Add description in target debugs to distinguish RN Bridge and reanimated #54198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ export default class OpenDebuggerKeyboardHandler {
`Multiple debug targets available, please select:\n ${targets
.slice(0, 9)
.map(
({title}, i) =>
`${styleText(['white', 'inverse'], ` ${i + 1} `)} - "${title}"`,
({title, description}, i) =>
`${styleText(['white', 'inverse'], ` ${i + 1} `)} - "${title} (${description})"`,
Comment on lines +110 to +111
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could tweak this to disambiguate only when there are conflicting titles in the target list. This would prevent showing the verbose description field in the default case.

Suggested change
({title, description}, i) =>
`${styleText(['white', 'inverse'], ` ${i + 1} `)} - "${title} (${description})"`,
const hasDuplicateTitles =
new Set(targets.map(target => target.title)).size < targets.length;
this.#setTerminalMenu(
`Multiple debug targets available, please select:\n ${targets
.slice(0, 9)
.map(
({title, description}, i) =>
`${styleText(['white', 'inverse'], ` ${i + 1} `)} - "${title}"${hasDuplicateTitles ? ` (${description})` : ''}`,
)
.join('\n ')}`,
);

Copy link
Contributor Author

@dprevost-LMI dprevost-LMI Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the PR was "imported", which I'm unsure what does that mean. I do not mind doing the above. @cortinico let me know if this is required and can be done

Copy link
Member

@huntie huntie Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is feedback from me on this PR — it goes through a second review once imported. If you push changes here, we'll re-import :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup basically what @huntie said

)
.join('\n ')}`,
);
Expand Down
Loading