babel-preset: remove no longer needed plugin-syntax-dynamic-import plugin
#53446
+1
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
# Conflicts: # yarn.lock
Simek
force-pushed
the
@simek/babel-preset-remove-plugin-syntax-dynamic-import
branch
from
0fb508d to
6f3e28e
Compare
Job Summary for GradleTest All :: run_fantom_tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
@babel/plugin-syntax-dynamic-importBabel plugin is no longer required since@babel/[email protected]and can be safely removed from the preset and direct dependencies.Refs:
I have also make sure that we are using at least ES2020 evn preset in the Babel configs across the repository.
Changelog:
[GENERAL] [REMOVED] - babel-preset: remove no longer needed
plugin-syntax-dynamic-importpluginTest Plan:
All
test-citests are passing, also make sure that codegen andscripts/run-ci-javascript-tests.jsgenerates files correctly and all performed checks within that script are fine.