Skip to content

Conversation

tcuongd
Copy link
Collaborator

@tcuongd tcuongd commented May 15, 2025

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a cleanup() method to remove temporary files after model fitting, notably for CmdStan backends. Key changes include:

  • Adding a cleanup method stub and an implemented version in python/prophet/models.py.
  • Introducing the IStanBackend type in python/prophet/forecaster.py.
  • Updating python/prophet/diagnostics.py to call the newly added cleanup() method on the stan_backend.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
python/prophet/models.py Introduces two cleanup() methods; one is a stub and another with logic.
python/prophet/forecaster.py Adds the stan_backend attribute and IStanBackend import.
python/prophet/diagnostics.py Calls cleanup() on stan_backend and adds type annotation to prophet_copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants