fix: get image info before creating drawable to avoid IllegalStateException #2839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to mitigate crash caused by
IllegalStateExceptionthrown due to closable image reference being already closed when getting the image info.The crash is reported as #2826. On my end with version 3.6.0 I get following stack trace
To mitigate the crash I moved reading image info before creating drawable from it and to be also surrounded by try-catch.
Test Plan
Unfortunately I can't provide a test plan since the exception is thrown most likely due to some race condition.