[Nexthop] Support building with sccache #593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-nexthop
force-pushed
the
build-sccache
branch
2 times, most recently
from
5189c09 to
dd1a611
Compare
benoit-nexthop
force-pushed
the
build-sccache
branch
from
dd1a611 to
0c13a42
Compare
benoit-nexthop
force-pushed
the
build-sccache
branch
from
0c13a42 to
0ae7542
Compare
benoit-nexthop
changed the title
|
@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D86343218. |
benoit-nexthop
force-pushed
the
build-sccache
branch
from
0ae7542 to
e646599
Compare
Contributor
|
@benoit-nexthop has updated the pull request. You must reimport the pull request before landing. |
- Install sccache in Docker image - Add an extras mount directory and use it for sccache - Add --extra-cmake-defines argument to docker-build.py so the caller can pass CMAKE_C_COMPILER_LAUNCHER etc. to the build.
benoit-nexthop
force-pushed
the
build-sccache
branch
from
e646599 to
496c47a
Compare
Contributor
|
@benoit-nexthop has updated the pull request. You must reimport the pull request before landing. |
2 tasks
|
@joseph5wu merged this pull request in 2f9b90e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sccachein Docker image--extra-cmake-definesargument todocker-build.pyso the callercan pass
CMAKE_C_COMPILER_LAUNCHERetc. to the build.Motivation
Building FBOSS requires significant resources, the translation units are huge, often taking 1-4G of RAM, sometimes 6-8G, and linking requirements are even more onerous. On a machine with AMD EPYC 9655P (96 cores, 192 threads), in a VM using only 64 cores and 512GB of RAM, the FBOSS builds takes about 22min, but using
sccacheand with the cache warm from a previous build, build time can be as low as 2min with a 100% cache hit rate.Test Plan
Building with
--extra-cmake-defines {"CMAKE_C_COMPILER_LAUNCHER":"sccache","CMAKE_CXX_COMPILER_LAUNCHER":"sccache"}works. By default the build process is unchanged. This PR allows injectingsccacheor other similar tool into the build.