Tahansb: Add new profile IDs for backplane ports #586
Conversation
Description: This PR is used to add Profile IDs which will be added to Wedge800CA platform. PROFILE_200G_4_PAM4_RS544_OPTICAL = 61, PROFILE_200G_4_PAM4_RS544_COPPER = 62, PROFILE_400G_4_PAM4_RS544_OPTICAL = 63, PROFILE_400G_4_PAM4_RS544_COPPER = 64, PROFILE_800G_8_PAM4_RS544_OPTICAL = 65, PROFILE_800G_8_PAM4_RS544_COPPER = 66, Note: 1. ProfileID 57 will be added by PR#585(facebook#585). 2. ProfileID 58 and 59 will be added by PR#586(facebook#586). 3. So I add the new ID begin from 60.
Description: This PR is used to add Profile IDs which will be added to Wedge800CA platform. PROFILE_200G_4_PAM4_RS544_OPTICAL = 60 PROFILE_200G_4_PAM4_RS544_COPPER = 61 PROFILE_400G_4_PAM4_RS544_OPTICAL = 62 PROFILE_400G_4_PAM4_RS544_COPPER = 63 PROFILE_800G_8_PAM4_RS544_OPTICAL = 64 PROFILE_800G_8_PAM4_RS544_COPPER = 65 Note: 1. ProfileID 57 will be added by PR#585(facebook#585). 2. ProfileID 58 and 59 will be added by PR#586(facebook#586). 3. So I add the new ID begin from 60.
Description: This PR is used to add Profile IDs which will be added to Wedge800CA platform. PROFILE_200G_4_PAM4_RS544_OPTICAL = 60 PROFILE_200G_4_PAM4_RS544_COPPER = 61 PROFILE_400G_4_PAM4_RS544_OPTICAL = 62 PROFILE_400G_4_PAM4_RS544_COPPER = 63 PROFILE_800G_8_PAM4_RS544_OPTICAL = 64 PROFILE_800G_8_PAM4_RS544_COPPER = 65 Note: 1. ProfileID 57 will be added by PR#585(facebook#585). 2. ProfileID 58 and 59 will be added by PR#586(facebook#586). 3. So I add the new ID begin from 60.
| 400000,NPU,TRANSCEIVER,2,PAM4,RS544_2N,OPTICAL,SR2, | ||
| 400000,NPU,TRANSCEIVER,4,PAM4,RS544_2N,OPTICAL,SR4, | ||
| 800000,NPU,TRANSCEIVER,4,PAM4,RS544_2N,OPTICAL,SR4, | ||
| 400000,NPU,BACKPLANE,2,PAM4,RS544_2N,BACKPLANE,KR2, |
There was a problem hiding this comment.
Do we expect the backplane ports to use COPPER instead of BACKPLANE as the media type?
There was a problem hiding this comment.
When I used "BACKPLANE" as media type, got a compile error when generate the "platform_mapping.json":
File "/tmp/fbcode_builder_getdeps-ZvarZFBOSSZfbossZfboss_lihuaZbuildZfbcode_builder-root/build/fboss/fboss-platform-mapping-gen/fboss/lib/platform_mapping_v2/profile_settings.py", line 58, in get_speed_setting
Exception: ("Can't find speed setting for profile ", 58)
Failed to run target fboss-platform-mapping-gen
[root@7d5d7e12725e fboss_lihua]#
So I referred to tahan800bc_profile_settings.csv which also used COPPER as backplane media type.
However, I'll try to use BACKPLANE again and fix the compile issue, this may need to update the fboss/lib/platform_mapping_v2/helpers.py.
There was a problem hiding this comment.
If tahan800bc is using copper it should be fine to use it here as well, thanks
| 279,279,eth1/63/3,51,,,,0,0 | ||
| 280,280,eth1/63/5,51,,,,0,0 | ||
| 281,281,eth1/63/7,51,,,,0,0 | ||
| 1,1,eth1/1/1,38-47-51-52-53,,,,0,0 |
There was a problem hiding this comment.
Why do we have both 38 and 51? Do we need to support both 400g on 4 lanes and 400g and 2 lanes?
There was a problem hiding this comment.
Yes, according to the requirement, need supports below speed mode for front panel ports:
OSFP speed mode
- 2 x 800G
- 4 x 400G
- 8 x 200G
- 2 x 400G
- 8 x 100G
|
Also looks like tests are failing on the PR |
I cannot see nor download the detailed logs of "Facebook Internal - Builds & Tests", could you help to send the logs to me if possible? |
|
Fixed some issues causing internal test failures. Should be able to merge this |
Hi @birdsoup |
lihua-cls
force-pushed
the
tahansb_new_profid
branch
from
22a0f07 to
871311c
Compare
|
@lihua-cls has updated the pull request. You must reimport the pull request before landing. |
|
Hi @birdsoup I rebased the code, and also made some modifications as below:
If I used COPPER, I found that the diag_shell shown its medium type as "COPPER", and some of the ports seem difficult to link up, after I changed to BACKPLANE, they all able to UP: 
To solve the platform_mapping.json generating error below: need to change the helper.py, I changed the same way as PR#585: 
Please take a look whether it's OK.
Thanks |
|
@lihua-cls has updated the pull request. You must reimport the pull request before landing. |
Confirmed with our HW team, backplane should be the correct media type |
Hi @birdsoup Thanks for confirm, it's correct media type "Backplane" now, refer to diag_shell_client "ps" output below: |
3 participants
Description
This PR is the follow-up updates/fix for Santa Barbara(tahansb800bc) platform mapping:
Note: ProfileID 57 will be added by PR #585, so I add the new ID begin from 58 to avoid conflicts.
Update si_settings.csv, add items for all 8 lanes per core. Note: the value still default (referenced from icecube), need to be updated in future.
Fix an issue in static_mapping.csv for core ID 58 and 59.
Test Plan