fboss:fan_service: correct fan_service position PID algorithm #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D83296103. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the thermal team's testing, we find that the existing position PID algorithm will cause unstable fan speed. Although Meta now uses a new incremental PID algorithm, the position PID algorithm code remains. We need to keep it correct.
Motivation
Modify the position PID algorithm code. Modify the fan_service config PID parameters. After testing by the thermal team, the modified position PID algorithm works correctly.
Test Plan
Thermal team test it on the minipack3 unit. This is the minipack3 fan_service config file:
fan_service.json
Below is thermal team's test result:
Attach the test log:
osfp pid.txt