Ladakh800bcls: Platform: Add Ladakh800bcls platform config after bring up #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
2 times, most recently
from
8e319bb to
deb638a
Compare
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D82750730. |
|
Can you please split the PR. The platform_manager changes can be one PR. Other changes can come later. |
somasun
requested changes
Oct 2, 2025
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
from
deb638a to
4fce44c
Compare
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
chee-zhang
changed the title
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
from
54dc630 to
157101a
Compare
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
from
157101a to
b9e7089
Compare
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
This PR only contains platform_manager, others are in PR #584 |
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
chee-zhang
changed the title
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
from
b1ae75d to
57b5612
Compare
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D82750730. |
1. Remove other json, only keep platform_manager 2. Remove unused soft links 3. Remove unused `pmUnitName` 4. Add comments for `initRegSettings` 5. Add comments for COMe sensors 6. Add comments for RTM sensors
1. RTM change kernel device 2. Add one i2c bus according to the FPGA spec 3. Fix error of i2c bus start offset on dom according to FPGA spec 4. Fix error of reading PMBUS sensor 5. Fix error of i2c address of FAN 6. Fix error of HSCB sensor address according to HW spec
chee-zhang
force-pushed
the
anacapa_platform_config_draft_version
branch
from
57b5612 to
ef8cdaa
Compare
|
@chee-zhang has updated the pull request. You must reimport the pull request before landing. |
|
@mikechoifb merged this pull request in bb925b5. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
…manager, sensor_service configuration after bring up (#584) Summary: # Description This PR is about Ladakh800bcls platform configurations for EVT1 phase. # Motivation ## led_manager Based on Ladakh800bcls HW Design Specification EVT1, the LEDs below should be added. 1. 4x Tri-color LEDs for status indication, one PWR LED, one Sys LED, SMB LED and one FAN LED. 2. 6x Bi-color LEDs for FAN tray. ## fw_util Based on Ladakh800bcls HW Design Specification EVT1 and the FPGA Register Map, the following upgrade devices should be added. <img width="836" height="482" alt="image" src="https://github.com/user-attachments/assets/d70e2f82-a219-4758-b850-b2da50ff5451" /> ## sensor_service Based on Ladakh800bcls HW Design Specification EVT1. 1. Add the thermal sensors. 2. Add the voltage and current detection sensors. ## fan_service Based on Ladakh800bcls HW Design Specification EVT1. <img width="489" height="134" alt="486578675-240493a7-4d35-4c2e-8dbf-f2717151488a" src="https://github.com/user-attachments/assets/eee02620-5bca-4937-830a-1cc8bf4ad144" /> 1. The CPU_UNCORE_TEMP, INLET_TEMP on RTM_L, INLET_TEMP on RTM_R, MCB_POWER_BRICK3_TEMP are considered in the draft version. 3. 6 fans are considered. Pull Request resolved: #584 Test Plan: 1. Used `jq` command to pretty the format. 2. Compilation and config validation have passed based on #537 ``` I1028 23:21:17.308879 2308103 ConfigGenerator.cpp:113] Processing platform ladakh800bcls in /work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls I1028 23:21:17.309004 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/bsp_tests.json" I1028 23:21:17.312866 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/fan_service.json" I1028 23:21:17.316480 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/fw_util.json" I1028 23:21:17.319443 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/led_manager.json" I1028 23:21:17.321964 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/sensor_service.json" I1028 23:21:17.327983 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/showtech.json" I1028 23:21:17.330609 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/platform_manager.json" I1028 23:21:17.331477 2308103 ConfigValidator.cpp:557] Validating platform_manager config I1028 23:21:17.331497 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot COMESE_SLOT... I1028 23:21:17.331509 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot MCB_SLOT... I1028 23:21:17.331516 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RTM_L_SLOT... I1028 23:21:17.331523 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RTM_R_SLOT... I1028 23:21:17.331530 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RUNBMC_SLOT... I1028 23:21:17.331538 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot SMB_L_SLOT... I1028 23:21:17.331546 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot SMB_R_SLOT... I1028 23:21:17.331553 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit BMC in Slot RUNBMC_SLOT... I1028 23:21:17.331563 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit LADAKH800BCLS_MCB in Slot MCB_SLOT... I1028 23:21:17.331655 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit NETLAKE in Slot COMESE_SLOT... I1028 23:21:17.331671 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit RTM_L in Slot RTM_L_SLOT... I1028 23:21:17.331683 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit RTM_R in Slot RTM_R_SLOT... I1028 23:21:17.331695 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit SMB_L in Slot SMB_L_SLOT... I1028 23:21:17.331708 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit SMB_R in Slot SMB_R_SLOT... I1028 23:21:17.331721 2308103 ConfigValidator.cpp:654] Validating Symbolic links... I1028 23:21:17.335198 2308103 ConfigValidator.cpp:661] Validating Transceiver symbolic links... I1028 23:21:17.335443 2308103 ConfigValidator.cpp:16] Validating sensor_service config I1028 23:21:17.336406 2308103 CrossConfigValidator.cpp:25] Cross validating sensor_service config I1028 23:21:17.337705 2308103 ConfigValidator.cpp:47] Validating fan_service config I1028 23:21:17.337830 2308103 CrossConfigValidator.cpp:54] Cross validating fan_service config I1028 23:21:17.337946 2308103 ConfigValidator.cpp:10] Validating data_corral_service config I1028 23:21:17.337960 2308103 ConfigValidator.cpp:12] Validating the system LED config I1028 23:21:17.337967 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: FAN I1028 23:21:17.337973 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: PWR I1028 23:21:17.337980 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: SMB I1028 23:21:17.337990 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN1 I1028 23:21:17.337997 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN2 I1028 23:21:17.338003 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN3 I1028 23:21:17.338011 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN4 I1028 23:21:17.338018 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN5 I1028 23:21:17.338026 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN6 I1028 23:21:17.338032 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: PWR I1028 23:21:17.338043 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: SMB_L I1028 23:21:17.338050 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: SMB_R ``` [build.log](https://github.com/user-attachments/files/23201921/build.log) 3. The HW tests below passed. *To be verified with new name* Reviewed By: Protick666 Differential Revision: D85795573 Pulled By: mikechoifb fbshipit-source-id: ac0b1ae9c63ccf45b1c868b35161b17eeeb3152d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about Ladakh800bcls platform configurations for EVT1 phase.
Motivation
platform_manager
Based on Ladakh800bcls HW Design Specification EVT1, the following boards should be added.
bring up bugfix
initRegSettingsTest Plan
jqcommand to pretty the format.build.log
To be verified with new name