Add rust_cxx_bridge CMake function #43
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
a68947d to
896c25d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
896c25d to
cf3eabe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
cf3eabe to
de95465
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
de95465 to
eb1160b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
eb1160b to
fe0a721
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
jdelliot
force-pushed
the
export-D51160627
branch
from
fe0a721 to
bb7fa33
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
Summary: X-link: facebookincubator/hsthrift#120 X-link: facebook/folly#2096 X-link: facebookexperimental/edencommon#14 X-link: facebook/mvfst#322 X-link: facebookincubator/delos_core#9 X-link: facebook/fboss#166 X-link: https://github.com/facebookincubator/zstrong/pull/617 X-link: facebookincubator/katran#208 X-link: facebookincubator/fizz#102 X-link: facebookexternal/traffixr#4 X-link: facebook/watchman#1173 X-link: facebook/proxygen#473 X-link: facebook/hhvm#9411 X-link: facebook/fbthrift#587 X-link: facebookincubator/velox#7518 We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd. This function creates C++ bindings using the [cxx] crate. Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390 Reviewed By: xavierd Differential Revision: D51160627
jdelliot
force-pushed
the
export-D51160627
branch
from
bb7fa33 to
7e06a92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51160627 |
|
Hi @jdelliot! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
2 participants
Summary:
We need a better way to create cxxbridges - something that uses the recommended method of cxxbridge-cmd.
This function creates C++ bindings using the [cxx] crate.
Original function found here: https://github.com/corrosion-rs/corrosion/blob/master/cmake/Corrosion.cmake#L1390
Differential Revision: D51160627