Skip to content

Passthrough wasm files to webpack internal loaders #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmrcunha wants to merge 2 commits into from
Closed

Passthrough wasm files to webpack internal loaders #7911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd0b25
Passthrough wasm files to webpack internal loaders
pmrcunha Oct 30, 2019
5c23204
Add wasm to file extension resolution
pmrcunha Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-scripts/config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const moduleFileExtensions = [
'json',
'web.jsx',
'jsx',
'wasm',
];

// Resolve file paths in the same order as webpack
Expand Down
4 changes: 2 additions & 2 deletions packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,9 +568,9 @@ module.exports = function(webpackEnv) {
loader: require.resolve('file-loader'),
// Exclude `js` files to keep "css" loader working as it injects
// its runtime that would otherwise be processed through "file" loader.
// Also exclude `html` and `json` extensions so they get processed
// Also exclude `html`, `wasm` and `json` extensions so they get processed
// by webpacks internal loaders.
exclude: [/\.(js|mjs|jsx|ts|tsx)$/, /\.html$/, /\.json$/],
exclude: [/\.(js|mjs|jsx|ts|tsx|wasm)$/, /\.html$/, /\.json$/],
Copy link
Contributor

@ianschmitz ianschmitz Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! If we were to make this change, perhaps we should add the extension to

create-react-app/packages/react-scripts/config/paths.js

Line 49 in b4fe788

const moduleFileExtensions = [

Presumably you could then import ./foo which could resolves ./foo.wasm. Webpack appears to support this behavior by default: https://webpack.js.org/configuration/resolve/#resolveextensions

Copy link
Author

@pmrcunha pmrcunha Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I made and tested the change you suggested.
Also, here's a test repo, for reference: https://github.com/pmrcunha/cra-wasm-test

options: {
name: 'static/media/[name].[hash:8].[ext]',
},
Expand Down