Skip to content

Add wasm support (#4912) #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add wasm support (#4912) #5924

wants to merge 2 commits into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Nov 29, 2018

Fix #4912

Upgrade webpack to latest to fix build error, see webpack/webpack#8261

@iansu
Copy link
Contributor

iansu commented Nov 29, 2018

This will also need some tests, probably here: https://github.com/facebook/create-react-app/tree/master/packages/react-scripts/fixtures/kitchensink/src/features/webpack.

We will need some wasm code that we can load and execute in the tests to verify this is working properly.

@0xcaff 0xcaff mentioned this pull request Dec 16, 2018
@stale
Copy link

stale bot commented Dec 29, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 29, 2018
@pd4d10
Copy link
Contributor Author

pd4d10 commented Dec 30, 2018

Closing since @0xcaff has already working on it at #6049

@pd4d10 pd4d10 closed this Dec 30, 2018
@0xcaff
Copy link

0xcaff commented Dec 30, 2018

I'm not, I got stuck.

@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
@pd4d10 pd4d10 deleted the patch-1 branch November 22, 2019 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@next react-scripts(webpack.config.js) to resolve .wasm extension?
4 participants