Disable cell-segmentation of import paths for not(fbcode_build) #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83033385. (Because this pull request was imported automatically, there will not be any future comments.) |
cormacrelf
force-pushed
the
feature/no-cell-segmentation
branch
from
351fb34 to
58cf47a
Compare
|
Test |
|
Also, if you want to turn this into a runtime config flag so you can test and migrate behaviour internally that's fine, feel free to do so. You can make a very similar change that simply overrides |
cormacrelf
force-pushed
the
feature/no-cell-segmentation
branch
from
58cf47a to
3978603
Compare
This is achieved by not storing the build_file_cell in ImportPath any more.
cormacrelf
force-pushed
the
feature/no-cell-segmentation
branch
from
3978603 to
6202ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683, but leaves cell-segmentation in place for Meta.
Also fixes #890.
This is achieved by, under
cfg(not(fbcode_build)), by not storing the build_file_cell in ImportPath any more. I can confirm this fixes the test case on that issue (https://github.com/cormacrelf/buck2-tset-bug).This is a big improvement for users outside of Meta because previously it was practically impossible to use transitive sets. I have been writing some rules and have had to emulate the feature with regular starlark sets.