Skip to content

[HMA] Remove IContentTypeConfigStore from HMA #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[HMA] Remove IContentTypeConfigStore from HMA #1707

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
040ecb9
Remove IContentTypeConfigStore from HMA
haianhng31 Dec 11, 2024
8c5ff52
remove import interfaces from pytx in hma
haianhng31 Dec 11, 2024
61766ea
Merge branch 'main' of https://github.com/facebook/ThreatExchange int…
haianhng31 Dec 13, 2024
2a1d21b
add __init__.py to interfaces directory
haianhng31 Dec 13, 2024
73243f8
pytx move storage outside of cli
haianhng31 Dec 13, 2024
e44ffa0
pytx move storage outside of cli
haianhng31 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions hasher-matcher-actioner/src/OpenMediaMatch/storage/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import flask

from threatexchange.cli.storage.interfaces import IContentTypeConfigStore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are getting a mypy failure here because this might need a missing __init.py__ file in the interfaces directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know why mypy keeps complaining about not finding the module. I have checked:

  • threatexchange package is installed
  • threatexchange.storage.interfaces is a valid module
  • has __init__.py in interfaces directory

from threatexchange.utils import dataclass_json
from threatexchange.content_type.content_base import ContentType
from threatexchange.signal_type.signal_base import SignalType
Expand Down Expand Up @@ -50,16 +51,6 @@ class ContentTypeConfig:
content_type: t.Type[ContentType]


class IContentTypeConfigStore(metaclass=abc.ABCMeta):
"""Interface for accessing ContentType configuration"""

@abc.abstractmethod
def get_content_type_configs(self) -> t.Mapping[str, ContentTypeConfig]:
"""
Return all installed content types.
"""


@dataclass
class SignalTypeConfig:
"""
Expand Down
Loading