feat(deployment-status): tunnel TLS probe through HTTP proxy#326
Open
hiephm wants to merge 1 commit into
Open
Conversation
The dashboard deployment-status probe opened a raw socket to <domain>:443, which ignores HTTPS_PROXY. On a host that can only reach the internet via an outbound HTTP proxy this always reported "Backend: Unreachable" even when the target was up (the browser fallback, which uses the system proxy, succeeded). Honour HTTPS_PROXY/https_proxy and NO_PROXY: when a proxy applies, tunnel the TCP leg with HTTP CONNECT and run the TLS handshake over the tunnel, so the real peer certificate is still compared. Falls back to the original direct connection when no proxy applies. Supports basic proxy auth from the proxy URL. Pure stdlib, no new dependency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard deployment-status probe opened a raw socket to :443, which ignores HTTPS_PROXY. On a host that can only reach the internet via an outbound HTTP proxy this always reported "Backend: Unreachable" even when the target was up (the browser fallback, which uses the system proxy, succeeded).
Honour HTTPS_PROXY/https_proxy and NO_PROXY: when a proxy applies, tunnel the TCP leg with HTTP CONNECT and run the TLS handshake over the tunnel, so the real peer certificate is still compared. Falls back to the original direct connection when no proxy applies. Supports basic proxy auth from the proxy URL. Pure stdlib, no new dependency.