Skip to content

chore(deps): bump jackson-bom from 2.11.2 to 2.12.2#2868

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/maven/com.fasterxml.jackson-jackson-bom-2.12.2
Closed

chore(deps): bump jackson-bom from 2.11.2 to 2.12.2#2868
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/maven/com.fasterxml.jackson-jackson-bom-2.12.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 4, 2021

Bumps jackson-bom from 2.11.2 to 2.12.2.

Commits
  • 269d581 [maven-release-plugin] prepare release jackson-bom-2.12.2
  • 920e87a Prepare for 2.12.2 release
  • 5fd0265 Add version for "jackson-datatype-jsr353/jakarta" (classifier 'jakarta') as ...
  • da70049 Add missing definition for jackson-module-jaxb-annotations:jakarta wrt #40
  • 7d4f041 Fix #40
  • 30a20d1 back to snapshots
  • 6da153c [maven-release-plugin] prepare for next development iteration
  • f5249c3 [maven-release-plugin] prepare release jackson-bom-2.12.1
  • 7764bd7 Prepare for 2.12.1 release
  • 748d70a Push dependencies to snapshot again
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 4, 2021
@dependabot dependabot Bot requested review from manusa, oscerd and rohanKanojia March 4, 2021 07:33
@centos-ci
Copy link
Copy Markdown

Can one of the admins verify this patch?

@manusa
Copy link
Copy Markdown
Member

manusa commented Mar 4, 2021

Must fix serialization tests:

2020-11-30T11:22:24.0895453Z [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.803 s - in io.fabric8.kubernetes.client.dsl.internal.AbstractWatchManagerTest
2020-11-30T11:22:24.1546799Z [INFO] 
2020-11-30T11:22:24.1586013Z [INFO] Results:
2020-11-30T11:22:24.1597032Z [INFO] 
2020-11-30T11:22:24.1598030Z [ERROR] Failures: 
2020-11-30T11:22:24.1599050Z [ERROR]   SerializationTest.unmarshalCRDWithSchema:73 expected:<...er"
2020-11-30T11:22:24.1599944Z                 [y]:
2020-11-30T11:22:24.1600329Z                   ...> but was:<...er"
2020-11-30T11:22:24.1600692Z                 ["y"]:
2020-11-30T11:22:24.1601030Z                   ...>

#2644 (comment)
#2713 (comment)

@marcospereira
Copy link
Copy Markdown

Must fix serialization tests:

The easiest fix here is to change this line to use "y" (double-quoted) because of FasterXML/jackson-dataformats-text#226. I'm not sure this is the desirable fix, though. If it is, let me know and I can submit a PR that includes the dependency update and a fix for the test.

@manusa
Copy link
Copy Markdown
Member

manusa commented Mar 22, 2021

If that's the failing line, we should probably investigate it further since the y is used as the field name and not the value.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Apr 13, 2021

Superseded by #2987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants