-
Notifications
You must be signed in to change notification settings - Fork 26
[WIP] - Experiment caching #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[test] |
|
@miteshvp Your image is available in the registry: |
|
[test] |
|
@miteshvp Your image is available in the registry: |
| # Get the response if already cached earlier | ||
| # Sort package_list elements first | ||
| for i in input_json: | ||
| i['package_list'] = sorted(i['package_list']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @miteshvp I don't think this is going to work the way you want it to. This does not alter the original list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rootAvish - I did check on some local json and it works as expected. Also, the tests does prove the point that caching is in play. Still, what makes you think so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right sorry, I was thinking along the lines of a normal list. Cool, thanks.
|
Are we still not required to merge this? |
|
@rootAvish - we already did https://github.com/fabric8-analytics/fabric8-analytics-stack-analysis/blob/master/analytics_platform/kronos/deployment/rest_api.py#L138. |
No description provided.