Skip to content

Conversation

@miteshvp
Copy link
Contributor

@miteshvp miteshvp commented Jan 9, 2018

No description provided.

@miteshvp
Copy link
Contributor Author

miteshvp commented Jan 9, 2018

[test]

@centos-ci
Copy link
Collaborator

@miteshvp Your image is available in the registry: docker pull registry.devshift.net/bayesian/kronos:SNAPSHOT-PR-172

@miteshvp
Copy link
Contributor Author

miteshvp commented Jan 9, 2018

[test]

@centos-ci
Copy link
Collaborator

@miteshvp Your image is available in the registry: docker pull registry.devshift.net/bayesian/kronos:SNAPSHOT-PR-172

# Get the response if already cached earlier
# Sort package_list elements first
for i in input_json:
i['package_list'] = sorted(i['package_list'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @miteshvp I don't think this is going to work the way you want it to. This does not alter the original list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootAvish - I did check on some local json and it works as expected. Also, the tests does prove the point that caching is in play. Still, what makes you think so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right sorry, I was thinking along the lines of a normal list. Cool, thanks.

@rootAvish
Copy link
Contributor

Are we still not required to merge this?

@miteshvp
Copy link
Contributor Author

miteshvp commented Mar 6, 2018

@rootAvish - we already did https://github.com/fabric8-analytics/fabric8-analytics-stack-analysis/blob/master/analytics_platform/kronos/deployment/rest_api.py#L138.
But this is still open if we want to control cache-hit ratio for future use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants