Fixes #21: tokens passed via file#22
Open
mgoellnitz wants to merge 1 commit intofabianonline:masterfrom
Open
Conversation
mgoellnitz
force-pushed
the
secret_token_leak_21
branch
from
a196e12 to
67e22e7
Compare
bjornfor
reviewed
Jul 2, 2025
| _curl() { | ||
| curl -s -H "$AUTHORIZATION" -H "User-Agent: matrix.sh/$VERSION" "$@" | ||
| HEADERFILE="$HOME/.matrix.sh-headers" | ||
| if [ -z "$(grep "$AUTHORIZATION" $HEADERFILE)" ] ; then |
There was a problem hiding this comment.
Please quote all variables that don't need word splitting. (I know it's unlikely that $HOME has whitespace in it, but it's better to be safe than sorry.)
bjornfor
reviewed
Jul 2, 2025
| curl -s -H "$AUTHORIZATION" -H "User-Agent: matrix.sh/$VERSION" "$@" | ||
| HEADERFILE="$HOME/.matrix.sh-headers" | ||
| if [ -z "$(grep "$AUTHORIZATION" $HEADERFILE)" ] ; then | ||
| echo "User-Agent: matrix.sh/$VERSION" > $HEADERFILE |
There was a problem hiding this comment.
I would do (umask 0077; echo data > file) instead of separate chmod, to avoid ever having the secret in a world writable file.
bjornfor
reviewed
Jul 2, 2025
|
|
||
| _curl() { | ||
| curl -s -H "$AUTHORIZATION" -H "User-Agent: matrix.sh/$VERSION" "$@" | ||
| HEADERFILE="$HOME/.matrix.sh-headers" |
There was a problem hiding this comment.
I'd consider using $XDG_CACHE_HOME here, to avoid so many dotfiles in $HOME:
HEADERFILE=${XDG_CACHE_HOME:-"$HOME"/.cache}/matrix.sh/headers
mkdir -p "$(dirname "$HEADERFILE")"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.