-
-
Notifications
You must be signed in to change notification settings - Fork 281
feat: added Slovak i18n #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: added Slovak i18n #1334
Conversation
Someone is attempting to deploy a commit to the Valibot Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks (and sounds) good to me, Slovak is my first language.
base64: (issue) => `Neplatný Base64: Prijaté ${issue.received}`, | ||
bic: (issue) => `Neplatný BIC: Prijaté ${issue.received}`, | ||
bytes: (issue) => `Neplatné bajty: Očakávané ${issue.expected}, ale prijaté ${issue.received}`, | ||
check: (issue) => `Neplatný vstup: Prijaté ${issue.received}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: while less precise, it might sound more natural to use Neplatná vstupná hodnota
or perhaps Neplatná vložená hodnota
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its translated this way because I tried to keep translations consistent with other languages. Check en
or cz
translations for reference. But I agree with you, it would be more user readable this way.
decimal: (issue) => `Neplatné desatinné číslo: Prijaté ${issue.received}`, | ||
digits: (issue) => `Neplatné číslice: Prijaté ${issue.received}`, | ||
email: (issue) => `Neplatný email: Prijaté ${issue.received}`, | ||
emoji: (issue) => `Neplatné emoji: Prijaté ${issue.received}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Slovak uses emotikon
, it's debatable which is better to use, I think I'd still prefer emoji
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would also like to keep emoji
. It is well known and less odd for me personally than emotikon
This PR adds Slovak (sk) translations.
I translated all messages myself as a native Slovak speaker, aiming to keep them consistent with other languages.
I’d appreciate it if someone could review the translations for accuracy.