feat: add mongolian language #1224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for working on this PR! Do you know another dev that could review the translations for me? |
commit: |
dosubot
bot
added
the
size:XL
|
not bad 👍 |
There was a problem hiding this comment.
Pull Request Overview
Adds Mongolian (mn) support to the i18n package by extending types, adding translations, and wiring it into all build and export configurations.
- Extend
Languagetype and addmnentry - Add
packages/i18n/src/mn.tswith Mongolian messages - Wire
mninto build scripts,package.json,jsr.json, and.gitignore
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/src/types.ts | Add 'mn' to the Language union in types.ts |
| packages/i18n/src/mn.ts | New file: Mongolian translations for all validation messages |
| packages/i18n/scripts/build-npm.ts | Import and include mn in the NPM build script |
| packages/i18n/scripts/build-jsr.ts | Import and include mn in the JSR build script |
| packages/i18n/package.json | Expose ./mn paths in exports and add "mn" to the languages array |
| packages/i18n/jsr.json | Include !mn in ignore patterns and add all ./mn/... mappings in exports |
| packages/i18n/.gitignore | Add mn to ignore generated output directories |
Comments suppressed due to low confidence (1)
packages/i18n/src/mn.ts:4
- Add tests to ensure the Mongolian translation covers all keys in the
Language.specificinterface and matches other language packs.
const language: Language = {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mongolian for @valibot/i18n