feat: add guard action for narrowing using type predicates #1204
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
leaving this as draft now as i can't work out how to allow type guards that accept wider types than the current pipe type edit: switching back to the previous overloads half fixes the issue - it's now complaining when the output type is wider than the input type |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new guard action and corresponding type definitions to enable narrowing using type predicates in the transformation framework. Key changes include:
- Adding new API links and documentation for the guard action in markdown files.
- Defining and exporting new types and properties for GuardIssue and GuardAction across the API and type folders.
- Implementing the guard function in the library with associated tests covering functionality and type inference.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/src/routes/api/menu.md | Added menu links for guard and its related issues/actions. |
| website/src/routes/api/(types)/GuardIssue/* | Introduced new property definitions and documentation for GuardIssue. |
| website/src/routes/api/(types)/GuardAction/* | Added type properties and documentation for GuardAction. |
| website/src/routes/api/(actions)/guard/* | Created properties and docs for the guard action along with usage examples. |
| library/src/actions/guard/* | Implemented the guard function, interfaces, and tests ensuring correct behavior and type inference. |
commit: |
|
Thank you for working on this! I plan it for our v1.2 release. Feel free to mark it as ready once you are done. After that I will take over, review everything and merge it. |
|
found a fix (involving lots of |
2 participants
fixes #1089